Close toolbar Bug?

Using this command to close button don't work with 9.1 ?

Toolbar CLOSE name=*this LOCAL

I use it all the time without problem.

Is the toolbar you're trying to close actually local? If not then a Toolbar CLOSE LOCAL command won't affect it.

Hmm... well surely if you OPEN a toolbar with the LOCAL option, the command Albator uses works.

But I wonder, I don't think 'LOCAL' should discriminate against the way the toolbar was OPENED... rather just affect WHERE the toolbar will be opened and closed... i.e. the current/local lister.

If a toolbar is global then it's open in all listers and can't be closed in only one.

Feature request, maybe.

Yes, toolbar is LOCAL...

i use your Flatview toolbar and close button don't work too !!

Toolbar CLOSE don't work anymore

but Toolbar CLOSE NAME=Nudel-FlatView-Opus9 work

:confused:

Works for me so there must be something different between our two setups. Here's a video (1meg) showing what happens for me:

nudel.dopus.com/posts/close_local.wmv

If it helps, I'm opening the toolbar via this command:

Toolbar NAME=Nudel-Side-FlatView STATE=right LINE=0 TOGGLE LOCAL

And the close button runs this command:

Toolbar CLOSE name=*this LOCAL Set FLATVIEW=Off

i test tris command on my laptop under vista and it's the same thing... :cry:

it's work when i use a toogle button (like your toolbar). toogle show/hide toolbar and button on toolbar close toolbar.
but if i display toolbar by right clic on toolbar and select in list or check toolbar in custom windows, i cant close toolbar. and after, toogle button don't work too !!!

[quote="AlbatorIV"]
but if i display toolbar by right clic on toolbar and select in list or check toolbar in custom windows[/quote]

If you do that it's not a local toolbar, as you are opening it for all listers. A toolbar is only local if it is specifically opened with the LOCAL parameter specified for the Toolbar command.

I guess when I said it, it wasn't clear :wink:.

@jon if you're still listening... I wonder if you ever start saving toolbar on/off state inside Layouts, Styles, etc [nudge]... will the toolbars be implicitly 'local'? Right now, layouts will open with whatever 'global' toolbars are turned on.

Either way, seems to me that if you generally always use the same toolbars in your listers (global) then there times you might just want to turn one or more of those OFF in just one particular lister... like switching to an almost browser style 'Full Screen' mode and getting rid of all the menu and toolbars... but just in the 'current' lister.

blah blah... yadda yadda

Ok so...

If I open toolbar for all listers with menu or custom window (so no local), if I use LOCAL argument with close command in toolbar, command are ignored.
If I open toolbar with toggle button with local argument, if I use LOCAL argument with close command in toolbar, toolbar are closed.

Now testing...

If I opened toolbar by toggle button...

  1. Toggle button with local arg / toolbar with Toolbar CLOSE name=*this LOCAL => toggle work, toolbar is closed
  2. Toggle button with local arg / toolbar with Toolbar CLOSE name=*this => toggle work, toolbar is closed
  3. Toggle button with NO local arg / toolbar with Toolbar CLOSE name=*this LOCAL => toggle work, toolbar is NOT closed
  4. Toggle button with NO local arg / toolbar with Toolbar CLOSE name=*this => toggle work, toolbar is NOT closed
  • Local argument can be ignored in close command if toolbar is opened by button with local argument
  • Toolbar can not be closed if local argument is not in toggle button

Now if I open toolbar by menu or custom window...
5) Toggle button with local arg / toolbar with Toolbar CLOSE name=*this LOCAL => toggle do NOT work, toolbar is NOT closed
6) Toggle button with local arg / toolbar with Toolbar CLOSE name=*this => toggle do NOT work, toolbar is NOT closed
7) Toggle button with NO local arg / toolbar with Toolbar CLOSE name=*this LOCAL => toggle work, toolbar is NOT closed
8) Toggle button with NO local arg / toolbar with Toolbar CLOSE name=*this => toggle work, toolbar is NOT closed

So...

  • Toolbar opened with menu or custom window is not possible to close it locally (maybe a request)
  • Toggle button with local argument do not work if toolbar is opened with menu or custom window
  • Toolbar with or without local argument can not be close

Now if I replace *this by the name of toolbar...

  1. Ok, ok

  2. Ok, not

  3. Ok, not

  4. Ok, ok

  5. Not, not

  6. Not, ok

  7. Ok, not

  8. Ok, ok

So, there are difference when I use *this or names of toolbars

Summary…

  1. Ok, ok / ok, ok

  2. Ok, ok / ok, not => Difference

  3. Ok, not / ok, not

  4. Ok, not / ok, ok => Difference

  5. Not, not / not, not

  6. not, not / not, ok => Difference

  7. ok, not / ok, not

  8. ok, not / ok, ok => Difference

Just to say that before 9.1, Toolbar CLOSE NAME=*this LOCAL close toolbar when I open it by menu or custom window…
I use nudel’s flatview toolbar sometimes and I never use toggle button to open it.

There was a bug with CLOSE LOCAL where it would close all instances of a local (or maybe global as well? I never tried that) toolbar instead of only closing the one in the current window. Maybe when that bug was fixed it "broke" the behaviour you were relying on before, but that never should've worked in the first place since CLOSE LOCAL should not affect global toolbars.

If you want to open and close the toolbar as a global toolbar (i.e. opening it via the right-click menu you mention) then just remove the LOCAL argument from the command and it should work.

If you want it to be a local toolbar then leave the LOCAL argument in the command and change the way you open the toolbar.

Simple really.

[quote="AlbatorIV"]Now if I open toolbar by menu or custom window...
8) Toggle button with NO local arg / toolbar with Toolbar CLOSE name=*this => toggle work, toolbar is NOT closed[/quote]

No, no, no !!! Toolbar CLOSE NAME=*this don't work !!!! Only Toolbar CLOSE NAME="test" work !!!!

see capture
close.zip (610 KB)

Ah, yes that does look like a bug.

As far as I can tell if you do NAME=*this then it doesn't matter whether you also give the LOCAL argument or not; it always/only closes the toolbar if it's local.

I've filed a bug report.