First thumbnail image in script listview only shown after mouse hover

Help & Support
,
1

The following code gets called from the message loop (precisely my msgloophandler class sitting on top of the msgloop).
It adds the items that are selected to the listview. That works so far but the first item never shows the thumbnail on its own, only after the mouse hovers. So if one item is added, its thumbnail is blank. If multiple items are added, only the first one added stays blank, the others show the thumbnail. Full code here
sample.txt (4.3 KB) Dopus v13.20

image
image546×364 21.6 KB

function OnSelectionChanged(dlg, dlgMsg, loopContext)
{
	var tab = loopContext.sourceTab;
	tab.Update();
	var listview = dlg.Control("listview");
	listview.RemoveItem(-1);//clear listview

	var selected = tab.selected;
	ForEach(selected, function(item)
	{
		var lvItem = AddListviewItem(listview, item);
	});
}

function AddListviewItem(listView, item)
{
    var addedIndex = listView.AddItem(item.name);	
    if (addedIndex > -1)
{
        var lvItem = listView.GetItemAt(addedIndex);
	lvItem.icon = Script.LoadImage(item);

        return lvItem;
    }
    return null;
}

function ForEach(enumerable, delegate)
{
    for (var enumerator = new Enumerator(enumerable); !enumerator.atEnd(); enumerator.moveNext())
    {
        delegate(enumerator.item());
    }
}
2

Have you tried to execute .redraw=true on the listview after adding your item (while you're in the message loop)?

3

Thanks but sadly that does not help.

4

Can't run the sample code because it needs an include file.

If you can give us a minimal, self-contained script that demonstrates the problem we can investigate.

5

Sorry forgot about that. I rewrote it as a button. Select 1-x images and click the dialog's button.
Listview bug.dcf (5.0 KB)

<?xml version="1.0"?>
<button backcol="none" display="both" label_pos="right" textcol="none">
	<label>Listview bug</label>
	<icon1>#newcommand</icon1>
	<function type="script">
		<instruction>@script JScript</instruction>
		<instruction>function Populate(dlg, tab)</instruction>
		<instruction>{</instruction>
		<instruction>	tab.Update();</instruction>
		<instruction>	var listview = dlg.Control(&quot;listview&quot;);</instruction>
		<instruction>	listview.RemoveItem(-1);</instruction>
		<instruction />
		<instruction>	var selected = tab.selected;</instruction>
		<instruction>	ForEach(selected, function(item)</instruction>
		<instruction>	{</instruction>
		<instruction>		var lvItem = AddListviewItem(listview, item);</instruction>
		<instruction>	});</instruction>
		<instruction>}</instruction>
		<instruction />
		<instruction>function AddListviewItem(listView, item)</instruction>
		<instruction>{</instruction>
		<instruction>    var addedIndex = listView.AddItem(item.name);	</instruction>
		<instruction>    if (addedIndex &gt; -1)</instruction>
		<instruction>	{</instruction>
		<instruction>        var lvItem = listView.GetItemAt(addedIndex);</instruction>
		<instruction>		//Here comes the issue</instruction>
		<instruction>		//lvItem.icon = Script.LoadImage(item); //this code i use in my script</instruction>
		<instruction>		lvItem.icon = DOpus.LoadImage(item);</instruction>
		<instruction />
		<instruction>        return lvItem;</instruction>
		<instruction>    }</instruction>
		<instruction>    return null;</instruction>
		<instruction>}</instruction>
		<instruction />
		<instruction>function ForEach(enumerable, delegate)</instruction>
		<instruction>{</instruction>
		<instruction>    for (var enumerator = new Enumerator(enumerable); !enumerator.atEnd(); enumerator.moveNext())</instruction>
		<instruction>    {</instruction>
		<instruction>        delegate(enumerator.item());</instruction>
		<instruction>    }</instruction>
		<instruction>}</instruction>
		<instruction />
		<instruction />
		<instruction />
		<instruction>function OnClick(clickData)</instruction>
		<instruction>{</instruction>
		<instruction>	var source = clickData.func.sourcetab;</instruction>
		<instruction>	var dest = clickData.func.desttab;</instruction>
		<instruction>	var cmd = clickData.func.command;</instruction>
		<instruction>	var dlg = clickData.func.Dlg();</instruction>
		<instruction />
		<instruction>	dlg.detach = true;</instruction>
		<instruction>    dlg.template = &quot;dialog1&quot;;</instruction>
		<instruction>    dlg.title = &quot;Listview bug&quot;;</instruction>
		<instruction>    dlg.icon = &quot;info&quot;;</instruction>
		<instruction>    dlg.create();</instruction>
		<instruction />
		<instruction>	var msg;</instruction>
		<instruction>    do </instruction>
		<instruction>	{</instruction>
		<instruction>    	msg = dlg.GetMsg();</instruction>
		<instruction>        if (!msg.result)</instruction>
		<instruction>			return;</instruction>
		<instruction>				</instruction>
		<instruction>		var evnt =  msg.event || &quot;no event&quot;;</instruction>
		<instruction>		var val = String(msg.value || &quot;no value&quot;);</instruction>
		<instruction>		var ctrl = msg.control || &quot;no control&quot;;</instruction>
		<instruction>		var logMsg = &quot;Msgloop: Event = &apos;&quot; + evnt + &quot;&apos;\tValue = &apos;&quot; + val + &quot;&apos;\tControl = &apos;&quot; + ctrl + &quot;&apos;&quot;;</instruction>
		<instruction>        Log(logMsg);</instruction>
		<instruction />
		<instruction>		if(evnt == &quot;click&quot; &amp;&amp; ctrl == &quot;button1&quot;)</instruction>
		<instruction>		{</instruction>
		<instruction>			Populate(dlg, source);</instruction>
		<instruction>		}</instruction>
		<instruction>	}</instruction>
		<instruction>    while (msg);</instruction>
		<instruction>}</instruction>
		<instruction />
		<instruction />
		<instruction />
		<instruction>function Log(msg, e)</instruction>
		<instruction>{</instruction>
		<instruction>	DOpus.Output(String(msg), e || false);</instruction>
		<instruction>}</instruction>
		<instruction>==SCRIPT RESOURCES</instruction>
		<instruction>&lt;resources&gt;</instruction>
		<instruction>	&lt;resource name=&quot;dialog1&quot; type=&quot;dialog&quot;&gt;</instruction>
		<instruction>		&lt;dialog height=&quot;138&quot; lang=&quot;english&quot; width=&quot;270&quot;&gt;</instruction>
		<instruction>			&lt;control height=&quot;14&quot; name=&quot;button1&quot; title=&quot;Populate listview&quot; type=&quot;button&quot; width=&quot;78&quot; x=&quot;90&quot; y=&quot;124&quot; /&gt;</instruction>
		<instruction>			&lt;control height=&quot;120&quot; name=&quot;listview&quot; type=&quot;listview&quot; viewmode=&quot;largeicon&quot; width=&quot;270&quot; x=&quot;0&quot; y=&quot;0&quot; /&gt;</instruction>
		<instruction>		&lt;/dialog&gt;</instruction>
		<instruction>	&lt;/resource&gt;</instruction>
		<instruction>&lt;/resources&gt;</instruction>
	</function>
</button>
6

Are there any news on this topic? Thanks.

7

Will be a little while as we're working through all the reports over the holiday period.

But I can confirm the bug, and also offer a workaround. This will also improve performance:

function Populate(dlg, tab)
{
	tab.Update();
	var listview = dlg.Control("listview");
	listview.RemoveItem(-1);

	var selected = tab.selected;
	listview.redraw = false; // <--- ADD THIS
	ForEach(selected, function(item)
	{
		var lvItem = AddListviewItem(listview, item);
	});
	listview.redraw = true; // <-- AND THIS
}
8

Thanks that fixes the issue. Sorry if i was too impatient.

9

No problem. We've now fixed this for the next beta.

1 Like