Are you doing this inside a compression? have you extract the content of archive out to the folder? then only you make changes to Picture's Metadata and check if the metadata changes stays.
Afaik, archived file being open is always stored in a temp folder, any changes you make to them will not be save in archive, as when you open them again, they will just extract from archive again and to another temp folder. Or some archive does not allow editing.